mirror of
https://github.com/infinite-iroha/touka.git
synced 2026-02-03 00:41:10 +08:00
26cbf45074
This commit introduces a new, high-performance, and extensible WebDAV submodule, implemented natively without external dependencies. It also adds a high-level API to simplify common use cases and incorporates numerous fixes based on detailed code reviews. Features: - A core WebDAV handler supporting `PROPFIND`, `MKCOL`, `GET`, `PUT`, `DELETE`, `COPY`, `MOVE`, `LOCK`, `UNLOCK`. - An extensible design with `FileSystem` and `LockSystem` interfaces. - `MemFS`: A robust, tree-based in-memory filesystem for testing. - `OSFS`: A secure OS-based filesystem with protection against path traversal and symlink attacks. - `MemLock`: An in-memory locking system with graceful shutdown to prevent resource leaks. - A high-level API (`webdav.Serve`, `webdav.Register`) for ease of use. Fixes & Improvements: - Security: Patched directory traversal and symlink vulnerabilities. Ensured secure lock token generation. - RFC Compliance: Corrected status codes for `COPY`/`MOVE` (201 vs 204), `DELETE` on non-empty collections (409), and `Timeout` header parsing. - Performance: Implemented `sync.Pool` for object reuse and `sync/atomic` for file size management to reduce GC pressure. - Robustness: Fixed numerous bugs related to path handling, resource cleanup (goroutine leaks), and header parsing. Integration: - The Touka framework's core has been updated to recognize all necessary WebDAV methods. - Includes comprehensive unit tests and a working example.
53 lines
1.3 KiB
Go
53 lines
1.3 KiB
Go
// This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
// file, You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
// Copyright 2024 WJQSERVER. All rights reserved.
|
|
// All rights reserved by WJQSERVER, related rights can be exercised by the infinite-iroha organization.
|
|
package webdav
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/infinite-iroha/touka"
|
|
)
|
|
|
|
func TestRegister(t *testing.T) {
|
|
r := touka.New()
|
|
cfg := &Config{
|
|
FileSystem: NewMemFS(),
|
|
LockSystem: NewMemLock(),
|
|
}
|
|
Register(r, "/dav", cfg)
|
|
|
|
// Check if a WebDAV method is registered
|
|
req, _ := http.NewRequest("PROPFIND", "/dav/", nil)
|
|
w := httptest.NewRecorder()
|
|
r.ServeHTTP(w, req)
|
|
|
|
if w.Code == http.StatusNotFound {
|
|
t.Errorf("Expected PROPFIND to be registered, but got 404")
|
|
}
|
|
}
|
|
|
|
func TestServe(t *testing.T) {
|
|
r := touka.New()
|
|
dir, _ := os.MkdirTemp("", "webdav")
|
|
defer os.RemoveAll(dir)
|
|
|
|
closer, err := Serve(r, "/serve", dir)
|
|
if err != nil {
|
|
t.Fatalf("Serve failed: %v", err)
|
|
}
|
|
defer closer.Close()
|
|
|
|
// Check if a WebDAV method is registered
|
|
req, _ := http.NewRequest("OPTIONS", "/serve/", nil)
|
|
w := httptest.NewRecorder()
|
|
r.ServeHTTP(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Errorf("Expected OPTIONS to return 200, but got %d", w.Code)
|
|
}
|
|
}
|