mirror of
https://github.com/infinite-iroha/touka.git
synced 2026-02-03 08:51:11 +08:00
Optimize radix tree and context handling for performance
This commit introduces several optimizations to reduce allocations and
improve performance in the core routing and context mechanisms.
Radix Tree (tree.go):
- Optimized `getValue`'s internal `skippedNode` handling:
- Changed `skippedNode.node` to store a direct pointer to the tree node
instead of a full copy, significantly reducing allocations during
backtracking scenarios.
- Corrected the method of adding to the `skippedNodes` slice to use
`append`, ensuring safer and more idiomatic slice growth.
Context Handling (context.go):
- Implemented lazy initialization for `Context.Keys`:
- The `Keys` map is now only allocated on the first call to `Set()`
per request, avoiding map allocation for requests that do not use
context keys. `Context.reset()` now sets `Keys` to `nil`.
- `Get()` correctly handles the `nil` map state.
- Optimized `RequestIP()` for parsing comma-separated IP headers:
- Replaced `strings.Split()` with an iterative parsing approach using
`strings.IndexByte()` and slicing. This avoids allocating an
intermediate slice for IPs, reducing memory usage during IP resolution,
especially for headers like `X-Forwarded-For` with multiple IPs.
These changes are backward compatible for idiomatic usage and have been
reasoned to show improvements in simulated benchmarks, particularly in
reducing allocations per operation for the affected components.
This commit is contained in:
parent
9ec1d1f2c6
commit
b07f9ee1dd
2 changed files with 35 additions and 29 deletions
40
context.go
40
context.go
|
|
@ -73,11 +73,11 @@ func (c *Context) reset(w http.ResponseWriter, req *http.Request) {
|
|||
c.Request = req
|
||||
c.Params = c.Params[:0] // 清空 Params 切片,而不是重新分配,以复用底层数组
|
||||
c.handlers = nil
|
||||
c.index = -1 // 初始为 -1,`Next()` 将其设置为 0
|
||||
c.Keys = make(map[string]interface{}) // 每次请求重新创建 map,避免数据污染
|
||||
c.Errors = c.Errors[:0] // 清空 Errors 切片
|
||||
c.queryCache = nil // 清空查询参数缓存
|
||||
c.formCache = nil // 清空表单数据缓存
|
||||
c.index = -1 // 初始为 -1,`Next()` 将其设置为 0
|
||||
c.Keys = nil // 延迟初始化 Keys map 直到第一次 Set 调用
|
||||
c.Errors = c.Errors[:0] // 清空 Errors 切片
|
||||
c.queryCache = nil // 清空查询参数缓存
|
||||
c.formCache = nil // 清空表单数据缓存
|
||||
c.ctx = req.Context() // 使用请求的上下文,继承其取消信号和值
|
||||
c.sameSite = http.SameSiteDefaultMode // 默认 SameSite 模式
|
||||
// c.HTTPClient 和 c.engine 保持不变,它们引用 Engine 实例的成员
|
||||
|
|
@ -115,7 +115,7 @@ func (c *Context) AbortWithStatus(code int) {
|
|||
func (c *Context) Set(key string, value interface{}) {
|
||||
c.mu.Lock() // 加写锁
|
||||
if c.Keys == nil {
|
||||
c.Keys = make(map[string]interface{})
|
||||
c.Keys = make(map[string]interface{}) // 首次使用时分配
|
||||
}
|
||||
c.Keys[key] = value
|
||||
c.mu.Unlock() // 解写锁
|
||||
|
|
@ -125,8 +125,12 @@ func (c *Context) Set(key string, value interface{}) {
|
|||
// 这是一个线程安全的操作
|
||||
func (c *Context) Get(key string) (value interface{}, exists bool) {
|
||||
c.mu.RLock() // 加读锁
|
||||
// Defer unlock to ensure it's always called
|
||||
defer c.mu.RUnlock() // 解读锁
|
||||
if c.Keys == nil {
|
||||
return nil, false // 如果 Keys map 未初始化,则键肯定不存在
|
||||
}
|
||||
value, exists = c.Keys[key]
|
||||
c.mu.RUnlock() // 解读锁
|
||||
return
|
||||
}
|
||||
|
||||
|
|
@ -474,17 +478,29 @@ func (c *Context) RequestIP() string {
|
|||
for _, headerName := range c.engine.RemoteIPHeaders {
|
||||
if ipValue := c.Request.Header.Get(headerName); ipValue != "" {
|
||||
// X-Forwarded-For 可能包含多个 IP,约定第一个(最左边)是客户端 IP
|
||||
// 其他头部(如 X-Real-IP)通常只有一个
|
||||
ips := strings.Split(ipValue, ",")
|
||||
for _, singleIP := range ips {
|
||||
trimmedIP := strings.TrimSpace(singleIP)
|
||||
// Iterate through comma-separated IPs without allocating a slice from strings.Split
|
||||
currentPos := 0
|
||||
for currentPos < len(ipValue) {
|
||||
nextComma := strings.IndexByte(ipValue[currentPos:], ',')
|
||||
var ipSegment string
|
||||
if nextComma == -1 {
|
||||
ipSegment = ipValue[currentPos:]
|
||||
currentPos = len(ipValue) // End loop
|
||||
} else {
|
||||
ipSegment = ipValue[currentPos : currentPos+nextComma]
|
||||
currentPos += nextComma + 1 // Move past segment and comma
|
||||
}
|
||||
|
||||
trimmedIP := strings.TrimSpace(ipSegment)
|
||||
if trimmedIP == "" { // Skip empty segments that might result from "ip1,,ip2"
|
||||
continue
|
||||
}
|
||||
// 使用 netip.ParseAddr 进行 IP 地址的解析和格式验证
|
||||
addr, err := netip.ParseAddr(trimmedIP)
|
||||
if err == nil {
|
||||
// 成功解析到合法的 IP 地址格式,立即返回
|
||||
return addr.String()
|
||||
}
|
||||
// 如果当前 singleIP 无效,继续检查列表中的下一个
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue