fix: address PR review for replacer — nil check, EscapedPath, scheme reuse, perf

- add req.URL nil guard
- use EscapedPath for {path} to avoid illegal header characters
- reuse reverseProxyRequestScheme for {scheme} consistency
- replace strings.NewReplacer with struct fields + strings.ReplaceAll

reverseproxy.go

@@ -264,32 +264,26 @@ func (ops *HeaderOps) Provision() error {
 }
 
 type reverseProxyReplacer struct {
-	req    *http.Request
+	method, host, path, query, scheme, uri, proto string
-	repl   *strings.Replacer
 }
 
 func newReverseProxyReplacer(req *http.Request) *reverseProxyReplacer {
-	r := &reverseProxyReplacer{req: req}
+	if req == nil || req.URL == nil {
-	if req != nil {
+		return &reverseProxyReplacer{}
-		uri := req.RequestURI
+	}
-		if uri == "" {
+	uri := req.RequestURI
-			uri = req.URL.RequestURI()
+	if uri == "" {
-		}
+		uri = req.URL.RequestURI()
-		scheme := "http"
+	}
-		if req.TLS != nil {
+	return &reverseProxyReplacer{
-			scheme = "https"
+		method: req.Method,
-		}
+		host:   req.Host,
-		r.repl = strings.NewReplacer(
+		path:   req.URL.EscapedPath(),
-			"{method}", req.Method,
+		query:  req.URL.RawQuery,
-			"{host}", req.Host,
+		scheme: reverseProxyRequestScheme(req),
-			"{path}", req.URL.Path,
+		uri:    uri,
-			"{query}", req.URL.RawQuery,
+		proto:  req.Proto,
-			"{scheme}", scheme,
-			"{uri}", uri,
-			"{proto}", req.Proto,
-		)
 	}
-	return r
 }
 
 func newReverseProxyReplacerFromHeader(hdr http.Header) *reverseProxyReplacer {
@@ -300,10 +294,28 @@ func (r *reverseProxyReplacer) Replace(s string) string {
 	if r == nil || s == "" {
 		return s
 	}
-	if r.repl == nil {
+	if r.method != "" {
-		return s
+		s = strings.ReplaceAll(s, "{method}", r.method)
 	}
-	return r.repl.Replace(s)
+	if r.host != "" {
+		s = strings.ReplaceAll(s, "{host}", r.host)
+	}
+	if r.path != "" {
+		s = strings.ReplaceAll(s, "{path}", r.path)
+	}
+	if r.query != "" {
+		s = strings.ReplaceAll(s, "{query}", r.query)
+	}
+	if r.scheme != "" {
+		s = strings.ReplaceAll(s, "{scheme}", r.scheme)
+	}
+	if r.uri != "" {
+		s = strings.ReplaceAll(s, "{uri}", r.uri)
+	}
+	if r.proto != "" {
+		s = strings.ReplaceAll(s, "{proto}", r.proto)
+	}
+	return s
 }
 
 type reverseProxyHandler struct {